Store data to buffers in default WebSocket protocol #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly detect 0xFF as end-of-message marker. This makes sure that partial UTF-8 characters or code points outside BMP do not cause connection breakages (although they are still not decoded correctly).
|
Would you mind adding a test case which captures the original issue? |
|
I didn't look as thoroughly as I should've for how to write tests. Added test cases for parsing single character splitted in multiple data chunks and non-BMP characters inside single buffer. |
|
Great, that looks much better. Thank you! |
|
Ah I just submitted a different work-around to this bug. This looks like it is probably a better fix. |
|
Switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly detect 0xFF as end-of-message marker. This makes sure that partial UTF-8 characters (signle character is splitted in multiple data chunks) or code points outside BMP do not cause connection breakages.
This is partial fix for #699. Emojis don't cause disconnection, but characters outside Basic Multilingual Plane are not decoded properly.